[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 10/16] xen/events: Refactor evtchn_to_irq array to be dynamically allocated



On 10/08/2013 08:49 AM, David Vrabel wrote:
@@ -482,13 +559,8 @@ static void shutdown_pirq(struct irq_data *data)
                return;
mask_evtchn(evtchn);
-
-       close.port = evtchn;
-       if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) != 0)
-               BUG();
-
-       bind_evtchn_to_cpu(evtchn, 0);
-       evtchn_to_irq[evtchn] = -1;
+       xen_evtchn_close(evtchn);
+       set_evtchn_to_irq(evtchn, -1);

Would it make sense to call set_evtchn_to_irq(evtchn, -1) from xen_evtchn_close()? If you are dismantling an event channel you probably always want to clear the irq mapping for that channel.

-boris





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.