[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] libxl: make libxl__poller_put tolerate p==NULL libxl_event_wait
Matthew Daley writes ("Re: [PATCH] libxl: make libxl__poller_put tolerate p==NULL libxl_event_wait"): > On Sat, Oct 12, 2013 at 12:12 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> > wrote: > > void libxl__poller_put(libxl_ctx *ctx, libxl__poller *p) > > { > > + if (!p) return; > > So before I go and send more libxl patches, what's the story with > single-line if statements like this? Is it acceptable in libxl (only?) > after all? From tools/libxl/CODING_STYLE: 4. Statements Don't put multiple statements on a single line. Don't put multiple assignments on a single line either. Error code paths with an if statement and a goto or a return on the same line are allowed. Examples: if (rc) goto out; Whether you think this is an error path is a matter of taste, I think. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |