Re: [Xen-devel] [PATCH net-next v4 3/5] xen-netback: Unconditionally set NETIF_F_RXCSUM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-10-11 at 16:06 +0100, Paul Durrant wrote:
> There is no mechanism to insist that a guest always generates a packet
> with good checksum (at least for IPv4)

Isn't this what feature-no-csum-offload is?

>  so we must handle checksum
> offloading from the guest and hence should set NETIF_F_RXCSUM.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: David Vrabel <david.vrabel@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  drivers/net/xen-netback/interface.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c 
> b/drivers/net/xen-netback/interface.c
> index 8e92783..cb0d8ea 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -321,7 +321,7 @@ struct xenvif *xenvif_alloc(struct device *parent, 
> domid_t domid,
>       dev->hw_features = NETIF_F_SG |
>               NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
>               NETIF_F_TSO;
> -     dev->features = dev->hw_features;
> +     dev->features = dev->hw_features | NETIF_F_RXCSUM;
>       SET_ETHTOOL_OPS(dev, &xenvif_ethtool_ops);
>  
>       dev->tx_queue_len = XENVIF_QUEUE_LENGTH;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel