[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] sched: fix race between sched_move_domain() and vcpu_wake()
On 10/10/2013 18:29, "David Vrabel" <david.vrabel@xxxxxxxxxx> wrote: > From: David Vrabel <david.vrabel@xxxxxxxxxx> > > sched_move_domain() changes v->processor for all the domain's VCPUs. > If another domain, softirq etc. triggers a simultaneous call to > vcpu_wake() (e.g., by setting an event channel as pending), then > vcpu_wake() may lock one schedule lock and try to unlock another. > > vcpu_schedule_lock() attempts to handle this but only does so for the > window between reading the schedule_lock from the per-CPU data and the > spin_lock() call. This does not help with sched_move_domain() > changing v->processor between the calls to vcpu_schedule_lock() and > vcpu_schedule_unlock(). > > Fix the race by taking the schedule_lock for v->processor in > sched_move_domain(). > > Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx> > Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx> > Cc: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Keir Fraser <keir@xxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |