Re: [Xen-devel] [PATCH] qemu-traditional: do not strip binaries during make install

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[PATCH] qemu-traditional: do not strip binaries during 
make install"):
> diff --git a/Makefile b/Makefile
> index 37c7066..594f0ef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -243,7 +243,7 @@ endif
>  install: all $(if $(BUILD_DOCS),install-doc)
>       mkdir -p "$(DESTDIR)$(bindir)"
>  ifneq ($(TOOLS),)
> -     $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> +     $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
...

I agree that the existing code is wrong but I worry that we are
replacing "cannot get it not to strip" with "cannot get it to strip".

Can you also replace the relevant $(INSTALL) with $(INSTALL_PROGRAM)
(defined appropriately if necessary) ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel