[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 6/7] xen/arm: Basic support for sunxi/sun7i platform.
On 10/08/2013 10:50 AM, Ian Campbell wrote: > On Fri, 2013-09-20 at 19:55 +0100, Julien Grall wrote: > >>> + >>> +static const char const *sunxi_dt_compat[] __initdata = >> >> It should be __initconst. > > Together with the 7/7 patch (uart blacklisting) doing this causes: > sunxi.c:21:26: error: sunxi_dt_compat causes a section type conflict > with sunxi_blacklist_dev > static const char const *sunxi_dt_compat[] __initconst = > ^ > sunxi.c:27:37: note: âsunxi_blacklist_devâ was declared here > static const struct dt_device_match sunxi_blacklist_dev[] > __initconst = > ^ > I'm not sure why this would be, but I notice that vexpress and exynos5 > both use __initdata for their dt_compat lists and __initconst for their > blacklists. > > Any thoughts? It's because the const should be after * in sunxi_dt_compat ie static const char * const sunxi_dt_compat[] __initconst = -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |