Re: [Xen-devel] [PATCHv9 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 09/10/13 16:26, Daniel Kiper wrote:
> On Tue, Oct 08, 2013 at 05:55:01PM +0100, David Vrabel wrote:
>> The series (for Xen 4.4) improves the kexec hypercall by making
>> Xen responsible for loading and relocating the image.  This allows
>> kexec to be usable by pv-ops kernels and should allow kexec to be
>> usable from a HVM or PVH privileged domain.
> 
> As I can see you taken some sugestions into account. Thanks. But... 
> Why did not you send this patch series to kexec@xxxxxxxxxxxxxxxxxxx 
> and my Oracle address?

I reckoned that the kexec list subscribers were sick of this Xen-only
series by now.  Omitting your Cc was accidental, sorry.

> Why did not you implemented kexec hypercall function to get info about
> loaded images?

Because it is not needed.

> What about setting GPRs to known value (e.g. 0 like in Linux Kernel) 
> before jumping into purgatory?

I have (repeatedly) explained why and you have not provided a sensible
reason why they should be zeroed.

> By the way, you do not need to save and restore %rdi, %rsi and %rbx 
> in relocate_pages() in xen/arch/x86/x86_64/kexec_reloc.S.

This is done so relocate_pages() behaves like a proper function with the
standard calling convention.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel