Re: [Xen-devel] [PATCH] Nested VMX: CR emulation fix up

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.10.13 at 17:46, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 10/08/2013 04:31 AM, Jan Beulich wrote:
>>>>> On 08.10.13 at 09:29, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>>> --- a/xen/include/asm-x86/hvm/vcpu.h
>>> +++ b/xen/include/asm-x86/hvm/vcpu.h
>>> @@ -100,6 +100,9 @@ struct nestedvcpu {
>>>        */
>>>       bool_t nv_ioport80;
>>>       bool_t nv_ioportED;
>>> +
>>> +    /* L2's control-resgister, just as the L2 sees them. */
>>> +    unsigned long       guest_cr[5];
> 
> This should be prefixed with nv_: all members of this structure are. In
> addition, struct hvm_vcpu has exact same member.

If anything, I think the pointless nv_ prefixes should be dropped
from the other members' names.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel