Re: [Xen-devel] [PATCH 08/11] evtchn: add FIFO-based event channel hypercalls and port ops

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 08/10/13 15:59, Jan Beulich wrote:
>>>> On 08.10.13 at 14:40, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
>> From: David Vrabel <david.vrabel@xxxxxxxxxx>
>>
>> Add the implementation for the FIFO-based event channel ABI.  The new
>> hypercall sub-ops (EVTCHNOP_init_control, EVTCHNOP_expand_array) and
>> the required evtchn_ops (set_pending, unmask, etc.).
>>
>> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks!

>> +static void set_priority_all(struct domain *d, unsigned int priority)
>> +{
>> +    unsigned int port;
>> +
>> +    for ( port = 1; port < d->max_evtchns; port++ )
>> +    {
>> +        if ( !port_is_valid(d, port) )
>> +            break;
>> +
>> +        evtchn_port_set_priority(d, evtchn_from_port(d, port), priority);
> 
> Couldn't you short cut this and call your internal function directly
> instead of through the generic wrapper?

I dithered over this at the time I added this and I don't recall why.
I'll make a note to change this up in a follow-up patch.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel