Re: [Xen-devel] [PATCH v2] libxl: remove qemu default devices for upstream qemu

[Fabio Fantoni <fabio.fantoni@xxxxxxx>]

Il 30/09/2013 13:53, Fabio Fantoni ha scritto:
> Remove default devices created by qemu. Qemu will create only devices
> defined by xen, since the devices not defined by xen are not usable.
> Remove deleting of empty floppy no more needed with nodefault.
Any comment on this?

Thanks for any reply.

> Changes from v1:
> Fix multi-line comment style
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> ---
>   tools/libxl/libxl_dm.c |   10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 2c6f5d9..eb71089 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -392,6 +392,13 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>       flexarray_append(dm_args, "-mon");
>       flexarray_append(dm_args, "chardev=libxl-cmd,mode=control");
>   
> +    /*
> +     * Remove default devices created by qemu. Qemu will create only devices
> +     * defined by xen, since the devices not defined by xen are not usable.
> +     * Remove deleting of empty floppy no more needed with nodefault.
> +     */
> +    flexarray_append(dm_args, "-nodefaults");
> +
>       if (b_info->type == LIBXL_DOMAIN_TYPE_PV) {
>           flexarray_append(dm_args, "-xen-attach");
>       }
> @@ -457,9 +464,6 @@ static char ** libxl__build_device_model_args_new(libxl__gc 
> *gc,
>       if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>           int ioemu_nics = 0;
>   
> -        /* Disable useless empty floppy drive */
> -        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> -
>           if (b_info->u.hvm.serial) {
>               flexarray_vappend(dm_args, "-serial", b_info->u.hvm.serial, NULL);
>           }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel