[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Patch 2/4] x86/hpet: Sanitise HPET ACPI table and warn about multiple tables
>>> On 07.10.13 at 15:26, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: > --- a/xen/arch/x86/acpi/boot.c > +++ b/xen/arch/x86/acpi/boot.c > @@ -276,6 +276,21 @@ static int __init acpi_parse_hpet(struct > acpi_table_header *table) > return -1; > } > > + if ( !hpet_tbl->address.address || !(hpet_tbl->address.address + 1) ) > + { > + printk(KERN_WARNING PREFIX "Bad HPET address %#lx\n", > + hpet_tbl->address.address); > + return -1; > + } Did you really encounter a system where this would trigger? > + > + /* > + * Hopefully someone might implement multiple HPET support in Xen. > + * Until then, warn the user if multiple HPET tables are found. > + */ > + if ( hpet_address ) > + printk(KERN_WARNING PREFIX > + "Xen only supports one HPET - Using latest table\n"); > + You perhaps miunderstood how multiple HPETs would be surfaced by firmware: Not via multiple HPET tables, but via objects in the ACPI object namespace. With that, a similar question to the above arises: Have you seen a system where multiple HPET tables get surfaced? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |