Re: [Xen-devel] [PATCH 4/4] kexec/xen: directly load images images into Xen

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Sun, Oct 06, 2013 at 03:55:58PM +0100, Andrew Cooper wrote:
> On 04/10/2013 22:33, Daniel Kiper wrote:
> >
> > +   xch = xc_interface_open(NULL, NULL, 0);
> > +   if (!xch)
> > +           return -1;
> > +
> > +   type = kexec_flags & KEXEC_TYPE_CRASH;
> > Why? Could not we unload normal kexec images?
>
> type is 0 for normal images and 1 for crash images.  This line does not
> prevent unloading of normal images in the slightest.

My fault. It is & not |. But it should be like in xen_kexec_load():

type = (kexec_flags & KEXEC_ON_CRASH) ? KEXEC_TYPE_CRASH : KEXEC_TYPE_DEFAULT;

or even

type = kexec_flags & ~KEXEC_ARCH_MASK;

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel