[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] hvm: Allow HVM guests to make console_io hypercall.
>>> On 27.09.13 at 23:17, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote: > The console_io hypercall is provided for PV guests and for HVM > guests it is done via the 0xe9 port. However the PV hypercall > is more efficient as it takes a string rather than one character > per write. While the change itself is fine, there are two questions arising from me looking at do_console_io() in this context: 1) While I can see why VERBOSE ought to control access to CONSOLEIO_write, I would think CONSOLEIO_read ought to be constrained to the control domain in any case. 2) xsm_console_io(), like quite a few other stubs in xsm/dummy.h, ignores its "d" parameter and uses current->domain instead. Is that really the right way (and if so, why are there other stubs that do honor their inputs)? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |