[Xen-devel] [PATCH] libxc: only munmap when something has actually been mapped in change_pte

[Matthew Daley <mattjd@xxxxxxxxx>]

Coverity-ID: 1055269
Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
---
How's this? It's hard to create a very meaningful commit title here, IMO...

 tools/libxc/xc_offline_page.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/libxc/xc_offline_page.c b/tools/libxc/xc_offline_page.c
index fbb53f5..8195efb 100644
--- a/tools/libxc/xc_offline_page.c
+++ b/tools/libxc/xc_offline_page.c
@@ -317,10 +317,10 @@ static int change_pte(xc_interface *xch, int domid,
                     goto failed;
                 }
             }
-        }
 
-        munmap(content, PAGE_SIZE);
-        content = NULL;
+            munmap(content, PAGE_SIZE);
+            content = NULL;
+        }
     }
 
     if ( xc_flush_mmu_updates(xch, mmu) )
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel