Re: [Xen-devel] [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-09-27 at 15:21 +0100, Julien Grall wrote:
> On 09/27/2013 03:10 PM, Ian Campbell wrote:
> > On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
> > 
> >>> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> >>>              }
> >>>          }
> >>>  
> >>> +        if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> >>
> >> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
> >> ARM64 it's used as an index in an array).
> > 
> > Yes, I thought I wanted to pass the hwid here, but it looks like I've
> > got my wires crossed.
> > 
> >> So you should used j here.
> > 
> > You mean cpuidx I think, after having moved the call after the cpuidx++
> 
> In fact I mean i. Because i = 0 (if it's the boot CPU) or cpuidx++ for
> non-boot CPU.

Right. Ignore the incremental patch I posted, the real one will have the
obvious change made ;-)

Ian



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel