[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC 0 PATCH 2/3] PVH dom0: move some pv specific code to static functions
On Thu, 26 Sep 2013 08:21:37 +0100 "Jan Beulich" <JBeulich@xxxxxxxx> wrote: > >>> On 25.09.13 at 23:03, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> > >>> wrote: > > +static __init void setup_pv_p2m_table( > ... > > + if ( l3tab ) > > + { > > + unmap_domain_page(l3tab); > > + l3tab = NULL; > > + } > > + l4tab = l4start + l4_table_offset(va); > > The way this l4tab gets used here (and l[123]tab below) makes > these names bogus - they should be pl[1234]e instead. The > original uses were just attributed to the desire of re-using > existing variables, which is mute with this stuff getting moved > into its own function. > > This also applies to the similarly named variables in > mark_pv_pt_pages_rdonly(). Ok, all done. Also, noticed the exhisting code for mark_pv_pt_pages_rdonly unnecessarily sets l[321]start in two places. thanks mukesh _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |