Re: [Xen-devel] [PATCH RFC v13 05/20] pvh: Disable unneeded features of HVM containers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.09.13 at 18:49, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> @@ -578,6 +592,9 @@ int hvm_domain_initialise(struct domain *d)
>  
>  void hvm_domain_relinquish_resources(struct domain *d)
>  {
> +    if ( is_pvh_domain(d) )
> +        return;
> +

Iirc in an earlier patch you're allocating ->arch.hvm_domain.params.
Which is supposed to be freed here, and hence would now be
leaked for PVH domains.

> @@ -1114,6 +1135,14 @@ int hvm_vcpu_initialise(struct vcpu *v)
>  
>      v->arch.hvm_vcpu.inject_trap.vector = -1;
>  
> +    if ( is_pvh_vcpu(v) )
> +    {
> +        v->arch.hvm_vcpu.hcall_64bit = 1;    /* PVH 32bitfixme. */
> +        /* This for hvm_long_mode_enabled(v). */
> +        v->arch.hvm_vcpu.guest_efer = EFER_SCE | EFER_LMA | EFER_LME;

Please fix the comment (perhaps just missing an "is").

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel