Re: [Xen-devel] [PATCH v3 3/3] Nested VMX: Fix IA32_VMX_CR4_FIXED1 msr emulation

["Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>]

Jan Beulich wrote on 2013-09-23:
>>>> On 22.09.13 at 07:34, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:
>> Jan Beulich wrote on 2013-09-11:
>>>>>> On 11.09.13 at 04:52, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>>>> +        hvm_cpuid(0x0, &eax, &ebx, &ecx, &edx);
>>>> +        if ( eax >= 0x7 )
>>> 
>>> Not a need to re-submit this patch, but for the future I'd
>>> recommend trying to avoid deep scope nesting where possible. Here
>>> that's pretty
>>> simple: If for whatever reason you dislike using the switch()
>>> approach I suggested in the v2 review, invert the condition above,
>>> and make the body of the if() simply "break;".
>> Can you give an example of how to use switch() instead if() here? I
>> cannot find out a nice switch() to simply the logic.
> 
> Please see the v4 series I just sent out.
I see it. It looks great. Thanks for the cleanup.

Best regards,
Yang



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel