Re: [Xen-devel] Ping: [PATCH 1/2] VMX: also use proper instruction mnemonic for VMREAD

["Nakajima, Jun" <jun.nakajima@xxxxxxxxx>]

On Mon, Sep 23, 2013 at 12:58 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 18.09.13 at 14:52, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>>>> On 16.09.13 at 16:43, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>>>>> On 16.09.13 at 16:38, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx> wrote:
>>>> @@ -667,74 +669,78 @@ static void vmx_ctxt_switch_to(struct vc
>>>>  void vmx_get_segment_register(struct vcpu *v, enum x86_segment seg,
>>>>                                struct segment_register *reg)
>>>>  {
>>>> -    uint32_t attr = 0;
>>>> +    unsigned long attr = 0, sel = 0, limit;
>>>
>>> This is a minor thing, but why do you initialize 'attr' and 'sel', but
>>> not 'limit'?
>>
>> Because limit gets initialized in all the case statements, but attr
>> and sel don't (for the GDTR and IDTR cases).

Ok.

 

>
> Is there anything else with this answered? If not, mind giving
> your ack?

Acked-by: Jun Nakajima <jun.nakajima@xxxxxxxxx>

 

--

Jun

Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel