[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v12 16/21] pvh: Use PV handlers for emulated forced invalid ops, cpuid, and IO



On 18/09/13 16:31, Jan Beulich wrote:
+void propagate_page_fault(unsigned long addr, u16 error_code)
+{
+    is_pvh_vcpu(current)
+        ? hvm_inject_page_fault(error_code, addr)
+        : pv_inject_page_fault(addr, error_code);
Even if not written down in CODINGSTYLE, the majority of other
cases in the code has the operators last thing on a line rather than
first.

In the case of boolean operators (&&, ||) I think it makes a lot more sense to put them at the beginning of the line; I think it makes the code easier to read.

But with the ?: operator I guess it's about the same either way, so I'll just go ahead and change it.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.