Re: [Xen-devel] [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2013-09-19 at 12:36 +0100, Tim Deegan wrote:
>  
> > -        PRINT("- Ready -\r\n")
> > +1:      PRINT("- Ready -\r\n")
> 
> Again, I'd prefer the label to go above (logically connected to the end
> of the block being skipped) to avoid the risk of someone adding new code
> just before '- Ready -' and having it be accidentally skipped.

I've been half thinking about defining some macros:

#define BOOT_CPU_START(name)  cbnz x22, boot_cpu_#name_skip
#define BOOT_CPU_END(name) boot_cpu_#name_skip:

So we would end up with:
BOOT_CPU_START(build_fixmap)
     /* All the stuff to build the fixmap */
BOOT_CPU_END(build_fixmap)

I'm in two minds about whether this is an improvement though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel