[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH net-next 2/2] xen-netback: handle frontends that fail to transition through Closing
> -----Original Message----- > From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx] > Sent: 20 September 2013 14:35 > To: Paul Durrant > Cc: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; David Vrabel; Wei Liu; > Ian Campbell > Subject: Re: [PATCH net-next 2/2] xen-netback: handle frontends that fail to > transition through Closing > > On Fri, Sep 20, 2013 at 01:56:31PM +0100, Paul Durrant wrote: > > Some old Windows frontends fail to transition through the xenbus Closing > > state and move directly from Connected to Closed. Handle this case > properly. > > > > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx> > > Cc: David Vrabel <david.vrabel@xxxxxxxxxx> > > Cc: Wei Liu <wei.liu2@xxxxxxxxxx> > > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> > > --- > > drivers/net/xen-netback/xenbus.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen- > netback/xenbus.c > > index a53782e..bcaa25b 100644 > > --- a/drivers/net/xen-netback/xenbus.c > > +++ b/drivers/net/xen-netback/xenbus.c > > @@ -265,6 +265,8 @@ static void frontend_changed(struct xenbus_device > *dev, > > break; > > > > case XenbusStateClosed: > > + if (dev->state == XenbusStateConnected) > > + disconnect_backend(dev); > > Could you please add a comment above this change stating that this is a > workaround for some old frontend that we cannot fix / upgrade. > > We would still like to later frontend goes through the normal connected > -> closing -> closed path. > Sure. I'll re-post the series with that change. Paul _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |