Re: [Xen-devel] [PATCH RFC v12 06/21] pvh: Introduce PVH guest type

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 18/09/13 15:10, Jan Beulich wrote:
> > > > On 13.09.13 at 18:25, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > Introduce new PVH guest type, flags to create it, and ways to identify it.
> >
> > To begin with, it will inherit functionality marked hvm_container.
> >
> > Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> with one minor comment:
>
> > --- a/xen/common/domctl.c
> > +++ b/xen/common/domctl.c
> > @@ -187,6 +187,8 @@ void getdomaininfo(struct domain *d, struct
> > xen_domctl_getdomaininfo *info)
> >   
> >       if ( is_hvm_domain(d) )
> >           info->flags |= XEN_DOMINF_hvm_guest;
> > +    else if ( is_pvh_domain(d) )
> > +        info->flags |= XEN_DOMINF_pvh_guest;
> I'd prefer constructs like this to be done as a switch statement.
Hmm, the resulting boilerplate takes up 11 lines rather than 4, but I 
guess that's OK with me...
Thanks,
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel