Re: [Xen-devel] [PATCH RFC v12 05/21] Introduce pv guest type and has_hvm_container macros

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.09.13 at 18:58, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> On 13/09/13 17:25, George Dunlap wrote:
>> @@ -2379,7 +2379,7 @@ static int __get_page_type(struct page_info *page, 
>> unsigned long type,
>>       {
>>           /* Special pages should not be accessible from devices. */
>>           struct domain *d = page_get_owner(page);
>> -        if ( d && !is_hvm_domain(d) && unlikely(need_iommu(d)) )
>> +        if ( d && is_pv_domain(d) && unlikely(need_iommu(d)) )
>>           {
>>               if ( (x & PGT_type_mask) == PGT_writable_page )
>>                   iommu_unmap_page(d, mfn_to_gmfn(d, page_to_mfn(page)));
> 
> This is one in particular I couldn't quite figure out what the PV/HVM 
> split was for, so I couldn't figure out whether to take this conditional 
> for PVH or not.

Yes, IOMMU mappings should follow the HVM model for PVH
afaict.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel