[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Xen-staging] [xen staging] ARM: parse separate DT properties for different commandlines
On 19 Sep 2013 09:29, "Andre Przywara" <andre.przywara@xxxxxxxxxx> wrote:
>>
>>> @@ -261,7 +261,12 @@ const char *device_tree_bootargs(const void *fdt)
>>> Â Â Â if ( node < 0 )
>>> Â Â Â Â Â return NULL;
>>>
>>> - Â Âprop = fdt_get_property(fdt, node, "bootargs", NULL);
>>> + Â Âprop = fdt_get_property(fdt, node, "xen,xen-bootargs", NULL);
>>> + Â Âif ( prop == NULL )
>>> + Â Â{
>>> + Â Â Â Âif (fdt_get_property(fdt, node, "xen,dom0-bootargs", NULL))
>>> + Â Â Â Â Â Âprop = fdt_get_property(fdt, node, "bootargs", NULL);
>>> + Â Â}
The logic seems wrong here, we returns bootargs only if the property
"xen,dom0-bootargs" exists. We should also check if the user give the dom0
command line via the multiboot module.
--
Julien Grall
Sent from my phone
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
