[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC v12 04/21] pvh prep: code motion
>>> On 13.09.13 at 18:25, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote: > @@ -1143,14 +1145,17 @@ int hvm_vcpu_initialise(struct vcpu *v) > > return 0; > > + fail6: > + nestedhvm_vcpu_destroy(v); > fail5: > - free_compat_arg_xlat(v); > + vlapic_destroy(v); > fail4: > - nestedhvm_vcpu_destroy(v); > + free_compat_arg_xlat(v); > fail3: > + tasklet_kill(&v->arch.hvm_vcpu.assert_evtchn_irq_tasklet); While everything else here looks fine, this call seems pretty pointless for a tasklet that was merely initialized (i.e. just the pointed to structure filled suitably), but never used for anything. Jan > hvm_funcs.vcpu_destroy(v); > fail2: > - vlapic_destroy(v); > + hvm_vcpu_cacheattr_destroy(v); > fail1: > return rc; > } > -- > 1.7.9.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |