Re: [Xen-devel] [PATCH 12/28] libxl: only free cputopology if it was allocated in libxl__get_numa_candidate

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2013-09-18 at 21:30 +1200, Matthew Daley wrote:
> On Wed, Sep 18, 2013 at 9:10 PM, Dario Faggioli
>
> > Anyway, for libxl_cputopology_list_free() (and also for
> > libxl_numainfo_list_free() if I really decide to patch it to make it
> > more "libxl style"), especially considering that something similar to
> > this happens in other places (as we're seeing in 13/28), is there
> > anything we can do for preventing this to come up again in future scans?
> 
> Simply marking the Defects in Coverity as "False Positive" (which I
> just did before) prevents them from bugging us in the future.
> 
Oh, awesome!

> A quick grep shows that the functions are only called in ~11 spots
> AFAICT; that's still small enough to sensibly allow manual overriding
> if any of the other invocations are complained about. 
>
Sounds good, thanks for explaining this. :-)

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel