Re: [Xen-devel] [PATCH 21/28] mini-os: fix nodename generation in init_netfront

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Matthew Daley, le Wed 18 Sep 2013 15:37:57 +1200, a écrit :
> Using strlen here makes no sense.
> 
> Coverity-ID: 1056053
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
>  extras/mini-os/netfront.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/extras/mini-os/netfront.c b/extras/mini-os/netfront.c
> index 4e087a5..a999985 100644
> --- a/extras/mini-os/netfront.c
> +++ b/extras/mini-os/netfront.c
> @@ -309,8 +309,10 @@ struct netfront_dev *init_netfront(char *_nodename, void 
> (*thenetif_rx)(unsigned
>  
>      if (!_nodename)
>          snprintf(nodename, sizeof(nodename), "device/vif/%d", netfrontends);
> -    else
> -        strncpy(nodename, _nodename, strlen(nodename));
> +    else {
> +        strncpy(nodename, _nodename, sizeof(nodename) - 1);
> +        nodename[sizeof(nodename) - 1] = 0;
> +    }
>      netfrontends++;
>  
>      if (!thenetif_rx)
> -- 
> 1.7.10.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel