Re: [Xen-devel] [PATCH 2/3] x86/AMD-Vi: Clean up code for handling IVRS IOAPIC override

[Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>]

On 09/16/2013 02:29 AM, Jan Beulich wrote:

On 14.09.13 at 01:30, <suravee.suthikulpanit@xxxxxxx> wrote:

@@ -745,10 +745,7 @@ static u16 __init parse_ivhd_device_special(
                 return 0;
             }
 
-            if ( test_bit(special->handle, ioapic_cmdline) )
-                AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-APIC %#x\n",
-                                special->handle);
-            else if ( ioapic_sbdf[special->handle].pin_2_idx )
+            if ( ioapic_sbdf[special->handle].pin_2_idx )

Once again: Why is this unnecessary?

Jan

Ok... you are right.  This part should handles the case when the IVRS entry has bad BDF.

Suravee

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel