Re: [Xen-devel] [xen-unstable test] 19268: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2013-09-14 at 07:54 +0100, xen.org wrote:
> flight 19268 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/19268/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-i386                    4 xen-build                 fail REGR. vs. 
> 19208
>  build-i386-oldkern            4 xen-build                 fail REGR. vs. 
> 19208

cc1: warnings being treated as errors
xen-mfndump.c: In function 'dump_ptes_func':
xen-mfndump.c:236: error: format '%lx' expects type 'long unsigned int', but 
argument 3 has type 'uint64_t'
xen-mfndump.c: In function 'lookup_pte_func':
xen-mfndump.c:305: error: format '%lx' expects type 'long unsigned int', but 
argument 5 has type 'uint64_t'
make[3]: *** [xen-mfndump.o] Error 1
make[3]: *** Waiting for unfinished jobs....

Since staging has quite a bit of stuff in it I have pushed:

commit 593470233ff38385df9dcf5690cc58c7a4fb290d
Author: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date:   Sat Sep 14 08:38:26 2013 +0100

    xen-mfndump: Use inttypes.h to format uint64_t types.
    
    Fixes 32-bit build:
    
    cc1: warnings being treated as errors
    xen-mfndump.c: In function 'dump_ptes_func':
    xen-mfndump.c:236: error: format '%lx' expects type 'long unsigned int', 
but argument 3 has type 'uint64_t'
    xen-mfndump.c: In function 'lookup_pte_func':
    xen-mfndump.c:305: error: format '%lx' expects type 'long unsigned int', 
but argument 5 has type 'uint64_t'
    
    Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff --git a/tools/misc/xen-mfndump.c b/tools/misc/xen-mfndump.c
index 3e8302e..ce73e5b 100644
--- a/tools/misc/xen-mfndump.c
+++ b/tools/misc/xen-mfndump.c
@@ -3,6 +3,7 @@
 #include <xc_core.h>
 #include <errno.h>
 #include <unistd.h>
+#include <inttypes.h>
 
 #include "xg_save_restore.h"
 
@@ -233,7 +234,7 @@ int dump_ptes_func(int argc, char *argv[])
     printf("\n");
 
     for ( i = 0; i < pte_num; i++ )
-        printf("  pte[%lu]: 0x%lx\n", i, ((const uint64_t*)page)[i]);
+        printf("  pte[%lu]: 0x%"PRIx64"\n", i, ((const uint64_t*)page)[i]);
 
     printf(" --- End of PTEs for domain %d, pfn=0x%lx (mfn=0x%lx) ---\n",
            domid, pfn, minfo.p2m_table[pfn]);
@@ -301,7 +302,7 @@ int lookup_pte_func(int argc, char *argv[])
 #define __MADDR_BITS_X86  ((minfo.guest_width == 8) ? 52 : 44)
 #define __MFN_MASK_X86    ((1ULL << (__MADDR_BITS_X86 - PAGE_SHIFT_X86)) - 1)
             if ( ((pte >> PAGE_SHIFT_X86) & __MFN_MASK_X86) == mfn)
-                printf("  0x%lx <-- [0x%lx][%lu]: 0x%lx\n",
+                printf("  0x%lx <-- [0x%lx][%lu]: 0x%"PRIx64"\n",
                        mfn, minfo.p2m_table[i], j, pte);
 #undef __MADDR_BITS_X86
 #undef __MFN_MASK_X8



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel