Re: [Xen-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-09-13 at 15:42 +0200, Fabio Fantoni wrote:
> >>> +            case 2:
> >>> +                flexarray_vappend(dm_args, 
> >>> "-device","ich9-usb-ehci1,id=usb,"
> >>> +                    "bus=pci.0,addr=0x1d.0x7", NULL);
> >>> +                for (i = 1; i < 4; i++)
> >>> +                    flexarray_vappend(dm_args, "-device", 
> >>> libxl__sprintf(gc,
> >>> +                        "ich9-usb-uhci%d,masterbus=usb.0,firstport=%d,"
> >>> +                        "bus=pci.0%s,addr=0x1d.%#x", i, 2*(i-1), i == 1 ?
> >>> +                        ",multifunction=on" : "", i-1), NULL);
> >>> +                break;
> > Please format this in some sort of halfway readable style.
> >
> > Using GCSPRINTF might help, as would putting newlines in more logical
> > places.
> >
> > Also you don't need _vappend, _append_pair would do.
> 
> Thanks for reply.
> I'll do them on next version if I understand right the "halfway readable 
> style".

I hope you can use your judgement here, rather than just wrapping at 80
chars with no regard for the readability.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel