Re: [Xen-devel] [PATCH v2 3/9] xen/arm: Reserve FDT via early module mechanism

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> >      ret = fdt_check_header(fdt);
> >      if ( ret < 0 )
> >          early_panic("No valid device tree\n");
> >  
> > +    mod = &early_info.modules.module[MOD_FDT];
> > +    mod->start = paddr & PAGE_MASK;
> 
> Why do we need to align the flat device tree and not the other modules
> (ie: initramfs, kernel,...)?

No reason, I just thought it might be a good idea when I wrote this.

> I looked at the memory code and it seems to handle non-aligned module.

In which case I'll drop the aligning.

> > +    mod->size = (fdt_totalsize(fdt) + ~PAGE_MASK) & PAGE_MASK;
> 
> You can use PAGE_ALIGN(fdt_totalsize(fdt)).

That's what I was searching for and failing to find!

Of course I don't need it now.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel