Re: [Xen-devel] [PATCH 6/9] cpufreq: missing check of copy_from_guest()

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Tim Deegan wrote:
> Coverity CID 1055131
> Coverity CID 1055132
> 
> Signed-off-by: Tim Deegan <tim@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> ---
>  xen/drivers/cpufreq/cpufreq.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/drivers/cpufreq/cpufreq.c
> b/xen/drivers/cpufreq/cpufreq.c 
> index 0de5d41..ab66884 100644
> --- a/xen/drivers/cpufreq/cpufreq.c
> +++ b/xen/drivers/cpufreq/cpufreq.c
> @@ -471,8 +471,12 @@ int set_px_pminfo(uint32_t acpi_id, struct
>              xen_processor_performance *dom0_px_in ret = -ENOMEM;
>              goto out;
>          }
> -        copy_from_guest(pxpt->states, dom0_px_info->states,
> -                                      dom0_px_info->state_count);
> +        if ( copy_from_guest(pxpt->states, dom0_px_info->states,
> +                             dom0_px_info->state_count) )
> +        {
> +            ret = -EFAULT;
> +            goto out;
> +        }
>          pxpt->state_count = dom0_px_info->state_count;
> 
>          if ( cpufreq_verbose )

Acked-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel