[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 7/9] ehci-dbgp: avoid division by zero.
>>> On 12.09.13 at 14:15, Tim Deegan <tim@xxxxxxx> wrote: > Unlikely to ever see hardware reporting 0 ports, but might as well > fail gracefully if we do. > > Coverity CID 1055266 > > Signed-off-by: Tim Deegan <tim@xxxxxxx> Well, that's a really pointless change, but anyway: Acked-by: Jan Beulich <jbeulich@xxxxxxxx> > --- > xen/drivers/char/ehci-dbgp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c > index 2504979..0ac2dd9 100644 > --- a/xen/drivers/char/ehci-dbgp.c > +++ b/xen/drivers/char/ehci-dbgp.c > @@ -1099,6 +1099,9 @@ try_next_port: > dbgp_printk("n_ports: %u\n", n_ports); > ehci_dbgp_status(dbgp, ""); > > + if ( n_ports == 0 ) > + return -1; > + > for ( i = 1; i <= n_ports; i++ ) > { > portsc = readl(&dbgp->ehci_regs->port_status[i-1]); > -- > 1.7.10.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |