Re: [Xen-devel] [V3 PATCH 2/3] PVH xen tools: libxc changes to build a PVH guest.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-09-11 at 14:41 -0700, Mukesh Rathor wrote:
> On Wed, 11 Sep 2013 11:03:45 +0100
> Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Tue, 2013-09-10 at 14:55 -0700, Mukesh Rathor wrote:
> > > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> > > -----
> > 
> > This needs to be exactly the "---" I quoted when I asked for it in
> > order to be affective (it causes git am to strip these comments)
> > 
> > > V2: Make pvh_features string const, and fail 32bit PVH guest
> > > creation. Move PVH check to xc_dom_gnttab_init().
> > > V3: let xc_dom_gnttab_hvm_seed be called for PVH.
> > > ---
> > 
> >  ^ Like this
> > 
> > >  tools/libxc/xc_dom.h      |    1 +
> > >  tools/libxc/xc_dom_core.c |    9 ++++
> > >  tools/libxc/xc_dom_x86.c  |   90
> > > +++++++++++++++++++++++++++++--------------- 3 files changed, 69
> > > insertions(+), 31 deletions(-) diff --git
> > > a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c index
> > > 0f367f6..faa7e0f 100644 --- a/tools/libxc/xc_dom_core.c
> > > +++ b/tools/libxc/xc_dom_core.c
> > > @@ -766,6 +766,15 @@ int xc_dom_parse_image(struct xc_dom_image
> > > *dom) goto err;
> > >      }
> > >  
> > > +    if ( dom->pvh_enabled )
> > > +    {
> > > +        const char *pvh_features = "writable_descriptor_tables|"
> > > +                                   "auto_translated_physmap|"
> > > +                                   "supervisor_mode_kernel|"
> > > +                                   "hvm_callback_vector";
> > > +        elf_xen_parse_features(pvh_features, dom->f_requested,
> > > NULL);
> > 
> > Is there a check somewhere that these features actually ended up being
> > available?
> 
> Right below it will check to make sure active features are supported.

Of course, sorry -- I was confused what parse features was filling in.

I'll reply to v4 with my ack.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel