Re: [Xen-devel] BUG: using smp_processor_id() in preemptible [00000000] code: blkback.1.xvdb/9138 caller is decrease_reservation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Sep 11, 2013 at 06:15:09PM +0100, Stefano Stabellini wrote:
[...]
> > Spoke too soon, starting a guest is fixed now, shutting it down oopses:
> > 
> > [  910.980798] vpn_bridge: port 1(vif13.0) entered disabled state
> > [  910.988352] vpn_bridge: port 1(vif13.0) entered disabled state
> > [  910.995427] device vif13.0 left promiscuous mode
> > [  911.001821] vpn_bridge: port 1(vif13.0) entered disabled state
> > [  911.364617] ------------[ cut here ]------------
> > [  911.371022] kernel BUG at drivers/xen/balloon.c:365!
> 
> That's a different issue, it seems to be the same one found by Wei and
> addressed by "xen/balloon: check whether a page is pointed to scratch
> page MFN".
> 
> However the patch was never committed as the last update was missing.
> 

In case Sander pick up the wrong patch:

That will never get committed because we took the other path, which is
removing the BUG_ON, which is the exact the same patch you provided
below.

Konrad might have forgotten to queue it up.

Wei.


> 
> Does the patch below solves the problem?
> 
> 
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 3101cf6..b52df76 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -349,8 +349,6 @@ static enum bp_state increase_reservation(unsigned long 
> nr_pages)
>               BUG_ON(page == NULL);
>  
>               pfn = page_to_pfn(page);
> -             BUG_ON(!xen_feature(XENFEAT_auto_translated_physmap) &&
> -                    phys_to_machine_mapping_valid(pfn));
>  
>               set_phys_to_machine(pfn, frame_list[i]);
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel