Re: [Xen-devel] [PATCH RFC 3/8] ns16550: make usable on ARM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-09-10 at 16:18 +0100, Jan Beulich wrote:
> >>> On 10.09.13 at 17:11, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Tue, 2013-09-10 at 16:00 +0100, Jan Beulich wrote:
> >> >>> On 10.09.13 at 16:18, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> >> > +    case 1:
> >> > +        return readb(addr);
> >> > +    case 4:
> >> > +        return readl(addr);
> >> 
> >> This won't work without changing the return type of the function.
> >> Or is this just mandating the access width, without the upper 24
> >> bits carrying meaningful data?
> > 
> > The latter, the registers are still 8 bytes, it's just the accesses.
> > Maybe I should mask.
> 
> No need to as long as the function return type is only 8 bits anyway.

True. I think it is worth at least a comment, I'll add one.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel