Re: [Xen-devel] [PATCH 1/8] x86: add missing va_end to hypercall_xlat_continuation

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/09/13 15:34, Matthew Daley wrote:
> Coverity-ID: 1056208
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
>  xen/arch/x86/domain.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index f7b0308..316ef04 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -1648,7 +1648,11 @@ int hypercall_xlat_continuation(unsigned int *id, 
> unsigned int mask, ...)
>      if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
>      {
>          if ( !test_bit(_MCSF_call_preempted, &mcs->flags) )
> +        {
> +            va_end(args);
>              return 0;
> +        }
> +
>          for ( i = 0; i < 6; ++i, mask >>= 1 )
>          {
>              if ( mask & 1 )


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel