Re: [Xen-devel] [PATCH] libxc/pm: Fix NULL pointer checks.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.13 at 11:29, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/tools/libxc/xc_pm.c
> +++ b/tools/libxc/xc_pm.c
> @@ -285,7 +285,7 @@ int xc_set_cpufreq_gov(xc_interface *xch, int cpuid, char 
> *govname)
>      DECLARE_SYSCTL;
>      char *scaling_governor = sysctl.u.pm_op.u.set_gov.scaling_governor;
>  
> -    if ( (xch < 0) || (!govname) )
> +    if ( !xch || !govname )

I'm very surprised the compiler didn't reject this - I'm unaware of
an extension that would allow pointers to be compared by other
than == and != (plus it's all but clear what e.g. a "negative"
pointer really is).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel