Re: [Xen-devel] [V2 PATCH 3/4] PVH xen tools: libxl changes to create a PVH guest.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-09-09 at 18:40 -0700, Mukesh Rathor wrote:
> On Mon, 9 Sep 2013 09:49:39 +0100
> Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Fri, 2013-09-06 at 17:28 -0700, Mukesh Rathor wrote:
> > > V2: set c_info->hap to default value of pvh, and use LOG(ERROR...).
> > >     Move PVH check to xc_dom_gnttab_init.
> > >     Move xl doc change here.
> > > 
> > > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> > > ---
> > >  docs/man/xl.cfg.pod.5        |    3 +++
> > >  tools/libxl/libxl.h          |    6 ++++++
> > >  tools/libxl/libxl_create.c   |   12 ++++++++++++
> > >  tools/libxl/libxl_dom.c      |    2 ++
> > >  tools/libxl/libxl_internal.h |    1 +
> > >  tools/libxl/libxl_types.idl  |    1 +
> > >  tools/libxl/libxl_x86.c      |    4 +++-
> > >  tools/libxl/xl_cmdimpl.c     |    1 +
> > >  8 files changed, 29 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> > > index 08d6cc4..4c925c9 100644
> > > --- a/docs/man/xl.cfg.pod.5
> > > +++ b/docs/man/xl.cfg.pod.5
> > > @@ -634,6 +634,9 @@ if your particular guest kernel does not
> > > require this behaviour then it is safe to allow this to be enabled
> > > but you may wish to disable it anyway.
> > >  
> > > +=item B<pvh=BOOLEAN>
> > > +Selects whether to run this guest in an HVM container. Default is
> > > 0.
> > 
> >                               ^ PV
> > 
> > Will help stop people becoming confused and thinking this turns on HVM
> > mode.
> 
> The change is under PV guest. HVM section os separate.

Right, those sections are pretty big, I worry that people will miss the
heading and/or not read properly.

>  But I can addit anyways.

Ta!

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel