Re: [Xen-devel] [PATCH] xen/x86: Introduce early_invalid_op() handler.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.09.13 at 16:17, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> +void __init  __attribute__((noreturn))
> +do_early_invalid_op(struct cpu_user_regs *regs)
> +{
> +    if ( *(u16 *)regs->eip == 0x0b0f )

Without even a range check on regs->eip? I don't think we want to
needlessly risk #PF or #GP here...

> +        printk("Early ud2 at %p - BUG/WARN/ASSERT perhaps?\n", 
> _p(regs->eip));
> +    else
> +        printk("Unidentified early #UD at %p\n", _p(regs->eip));
> +

You probably also meant to at least print the same raw stack
dump that do_early_page_fault() produces?

Jan

> +    for ( ; ; )
> +        halt();
> +}



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel