[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3] libxl: Spice disable-copy-paste support for upstream qemu
Il 09/09/2013 15:03, Ian Campbell ha scritto: On Tue, 2013-08-27 at 17:03 +0200, Fabio Fantoni wrote: Sorry for the delay in looking at this.Usage: spice_clipboard_sharing=1|0 (default=1) Disables Spice clipboard sharing (copy/paste). It requires spicevdagent enabled. Changes from v2: - Changed name of xl option from spicedisable_copypaste to spice_clipboard_sharing - Inverted the default based on option name. - Improved description. Requires this patch: libxl: Spice vdagent support for upstream qemu v4The normal way to post these would be as a series: [PATCH v4 0/2] spice vdagent support (intro) `- [PATCH v4 1/2] libxl: Spice vdagent support for upstream qemu `- [PATCH v4 2/2] libxl: Spice disable-copy-paste support for upstream qemu However I can't see any reason not to fold these into a single patch.Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx> --- docs/man/xl.cfg.pod.5 | 5 +++++ tools/libxl/libxl_create.c | 2 ++ tools/libxl/libxl_dm.c | 4 ++++ tools/libxl/libxl_types.idl | 1 + tools/libxl/xl_cmdimpl.c | 2 ++Please can you also patch tools/libxl/libxl.h to add a #define for LIBXL_HAVE_SPICE_VDAGENT (there is a comment and plenty of other examples of such things in libxl.h). If you keep the patches separate then this belongs in the first one, I think we can get away without a separate #define for the clipboard setting if they are committed around the same time.5 files changed, 14 insertions(+) diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 index 170bc11..ad9757c 100644 --- a/docs/man/xl.cfg.pod.5 +++ b/docs/man/xl.cfg.pod.5 @@ -1139,6 +1139,11 @@ by client, no mouse lag), automatic adjustment of screen resolution, copy and paste (text and image) between client and domU. It also requires vdagent service installed on domU o.s. to work. The default is 0.+=item B<spice_clipboard_sharing=BOOLEAN>+ +Disables Spice clipboard sharing (copy/paste). It requires spicevdagent +enabled. The default is true (1).I think this should default to off, since there are security implications to having it on. Thanks for reply, probably toworrow I'll post new version of patch with all your advices. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |