Re: [Xen-devel] [PATCH] xen-netback: count number required slots for an skb more carefully

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Sep 04, 2013 at 01:41:25PM +0100, Ian Campbell wrote:
[...]
> > > This bug was discussed back in July among Annie, Matt, Ian and I. We
> > > finally agreed to take Matt's solution. Matt agreed to post final
> > > version within a week but obviously he's too busy to do so. I was away
> > > so I didn't follow closely. Eventually it fell through the crack. :-(
> > 
> > I think I prefer fixing the counting for backporting to stable kernels.
> 
> That's a good argument. I think we should take this patch, or something
> very like it, now and then rebase the more complex thing on top.
> 

I take this as sort-of-ack by the maintainer.

David, please go ahead with your fix. I will post the other approach as
an improvement later on.

Wei.

> >  Xi's approach of packing the ring differently is a change in frontend
> > visible behaviour and seems more risky. e.g., possible performance
> > impact so I would like to see some performance analysis of that approach.
> 
> Yes.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel