Re: [Xen-devel] [PATCH] minios: Fix xenbus_rm() calls in frontend drivers

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Matt Wilson, le Wed 04 Sep 2013 17:25:20 -0700, a écrit :
> From: Ben Cressey <bcressey@xxxxxxxxxx>
> 
> The commit "minios: refactor xenbus state machine" caused "/state" to
> be appended to the local value of nodename. Previously the nodename
> variable pointed to dev->nodename.
> 
> The xenbus_rm() calls were not updated to reflect this change, and
> refer to paths that do not exist.
> 
> For example, shutdown_blkfront() for vbd 2049 would issue these calls:
>     xenbus_rm(XBT_NIL, "device/vbd/2049/state/ring-ref");
>     xenbus_rm(XBT_NIL, "device/vbd/2049/state/event-channel");
> 
> This patch restores the previous behavior, issuing these calls
> instead:
>     xenbus_rm(XBT_NIL, "device/vbd/2049/ring-ref");
>     xenbus_rm(XBT_NIL, "device/vbd/2049/event-channel");
> 
> In addition, remove cases where the error message pointer is already
> NULL and is then set to NULL. These are harmless, but suggest
> incorrect practice: the pointer should be passed to free() to
> deallocate memory prior to reassignment.
> 
> Signed-off-by: Ben Cressey <bcressey@xxxxxxxxxx>
> Reviewed-by: Matt Wilson <msw@xxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel