Re: [Xen-devel] [PATCH v2] tools: allow user to specify a system seabios binary

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-09-04 at 14:43 +0100, Andrew Cooper wrote:
> >> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> >> index aff8e56..fe56036 100644
> >> --- a/tools/firmware/Makefile
> >> +++ b/tools/firmware/Makefile
> >> @@ -7,7 +7,9 @@ INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR)
> >>  
> >>  SUBDIRS-y :=
> >>  SUBDIRS-$(CONFIG_OVMF) += ovmf
> >> -SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
> >> +ifeq ($(CONFIG_SEABIOS),y)
> >> +SUBDIRS-$(CONFIG_SEABIOS_COMP) += seabios-dir
> >> +endif
> > Perhaps:
> >
> > ifeq ($(CONFIG_SEABIOS_PATH),)
> 
> ifneq ?

If CONFIG_SEABIOS_PATH == "" then we want to build, so I think ifeq was
correct.

> 
> > SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir
> > endif
> >
> > TBH I'm not sure that being able to disable SeaBIOS at build time is
> > even useful.
> 
> Speaking as a downstream distro which doesn't currently use SeaBIOS, the
> ability to disable is very useful to prevent having the xen build system
> download yet more code.
> 
> While it is valid to have some combination of components built without
> using SeaBIOS, an option to disable is more useful than not, even if
> everyone is expected to use the default.

SeaBIOS should be built iff qemu-xen (upstream) is enabled. Since that
isn't an build time option I think think SeaBIOS needs to be either.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel