[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] tools: build debug qemu-xen in debug tools builds
On Wed, 2013-09-04 at 01:12 +1200, Matthew Daley wrote: > When building tools in debug mode (debug=y), pass --enable-debug when > configuring qemu-xen to enable some debug support (namely, to prevent > symbols from being stripped). This is from the installed binaries I suppose? Is this the only affect or are there others? I'd like some feedback from the qemu maintainers about whether this is an OK thing to do or not. Stefano/Anthony? Is it something we could consider doing unconditionally? Ian. > > Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx> > --- > tools/Makefile | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/Makefile b/tools/Makefile > index 0531f48..066df66 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -173,6 +173,12 @@ qemu-xen-dir-force-update: > $(GIT) reset --hard $(QEMU_UPSTREAM_REVISION); \ > fi > > +ifeq ($(debug),y) > +QEMU_XEN_ENABLE_DEBUG := --enable-debug > +else > +QEMU_XEN_ENABLE_DEBUG := > +endif > + > subdir-all-qemu-xen-dir: qemu-xen-dir-find > if test -d $(QEMU_UPSTREAM_URL) ; then \ > source=$(QEMU_UPSTREAM_URL); \ > @@ -181,6 +187,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find > fi; \ > cd qemu-xen-dir; \ > $$source/configure --enable-xen --target-list=i386-softmmu \ > + $(QEMU_XEN_ENABLE_DEBUG) \ > --prefix=$(PREFIX) \ > --source-path=$$source \ > --extra-cflags="-I$(XEN_ROOT)/tools/include \ _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |