[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] unmodified_drivers: change header string

>>> On 30.08.13 at 15:09, Olaf Hering <olaf@xxxxxxxxx> wrote:
> --- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
> +++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
> @@ -19,8 +19,8 @@
>   * Place - Suite 330, Boston, MA 02111-1307 USA.
>   */
> -#ifndef _XEN_PLATFORM_PCI_H
> -#define _XEN_PLATFORM_PCI_H

This is not only ugly, but plain pointless: Private headers,
especially when not included from other headers (and hence
there's no risk of multiple inclusion) don't need such guards at
all. Iow I'm not really willing to accept the above, but I wouldn't
mind a patch removing the guards.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.