Re: [Xen-devel] [PATCH V2] x86/AMD-Vi: Add additional check for invalid special->handle

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.13 at 19:34, <suravee.suthikulpanit@xxxxxxx> wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> 
> This patch add an additional logic to check for the often case when the
> special->handle is not initialized due to firmware bugs.
> but the special->usedid is correct. If users overide this using the
> command line option ivrs_ioapic, then it should use the value instead.
> ---
> This patch is supposed to follow the patches:
> [Xen-devel] [PATCH RFC 2/2] AMD IOMMU: allow command line overrides for 
> broken IVRS tables
> 
> Changes in V2:
>       - Fix logic to match the special->used_id with the value provided by 
> users.

As said in a previous reply - I'm convinced we can't fix things both
ways with just a single command line option: We need to know
which value to use as anchor (I'd generally think that ought to be
the value inside the square backets) and which value to use as
overrides.

And since my earlier patch was inspired by the Linux one - I don't
think Linux allows fixing up things the way you try to here either.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel