[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 2/2] AMD IOMMU: allow command line overrides for broken IVRS tables

>>> On 28.08.13 at 19:33, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx> 
>>> wrote:
> On 8/28/2013 10:43 AM, Jan Beulich wrote:
>>>>> On 28.08.13 at 16:59, Suravee Suthikulpanit 
>>>>> <suravee.suthikulpanit@xxxxxxx> wrote:
>>> The current patch does not handle the case where the "handle" value is
>>> mis-configured in the IVRS.
>> Right, but I don't think we can handle all possible cases here.
>> And in any case (not the least because your patch seems to be
>> incremental to my earlier one) - do you still see any issues with that
>> one, or does the mail here represent sort of an ack to that earlier
>> one (in its split form - as indicated earlier, I broke out the actual
>> bug fixes from the workaround, which really is an enhancement)?
> With the previous 2 patches, it would work fine for the case when the 
> IVHD special is missing for an IOAPIC.
> The code looks fine, but I don't have such systems which I can test on.  
> If it's working for Sander,
> then I think it should be sufficient testing.
> Acked-by: Suravee Suthikulpanit <suravee.suthikulapanit@xxxxxxx>
> However, it is not handling the case (which I have seen a lot) where,
> the special->handle is bad, but the special->used_id is ok. For this case,
> we should be able to match the used_id to the BDF values given by users.
> That's what my patch is trying to handle (but apparently failed... see 
> below).

Afaict that's going to require a second command line option,
since the code will need to know which piece of data from the
IVRS structure to consider valid, and which one(s) to replace.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.