[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: AVX instruction emulation fixes

  • To: Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Wed, 28 Aug 2013 13:49:57 +0100
  • Delivery-date: Wed, 28 Aug 2013 12:50:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac6j7Rl1q0lQD4jZlkC23IPOysxtyg==
  • Thread-topic: [PATCH] x86: AVX instruction emulation fixes

On 28/08/2013 09:32, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> - we used the C4/C5 (first prefix) byte instead of the apparent ModR/M
>   one as the second prefix byte
> - early decoding normalized vex.reg, thus corrupting it for the main
>   consumer (copy_REX_VEX()), resulting in #UD on the two-operand
>   instructions we emulate
> Also add respective test cases to the testing utility plus
> - fix get_fpu() (the fall-through order was inverted)
> - add cpu_has_avx2, even if it's currently unused (as in the new test
>   cases I decided to refrain from using AVX2 instructions in order to
>   be able to actually run all the tests on the hardware I have)
> - slightly tweak cpu_has_avx to more consistently express the outputs
>   we don't care about (sinking them all into the same variable)
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.